Pl 135485 debug log cut middle#32
Merged
Merged
Conversation
when cutting off long request responses or bodies, always keep a head and tail for better diagnostics re PL-135485 Assisted-by: Claude/sonnet-4.6
Member
|
Looks fine code wise, however it's not clear to me that there is a significant advantage of cutting off the middle instead of the end. If we want to do exact replay, the debug files do not help anyways, so this would only help for human comprehension. |
elikoga
approved these changes
Jun 3, 2026
Member
Author
|
The deal is this: if the request is small enough, then we can replay directly. However, if the request is too big and we need to figure out what's going on, having only the start of the conversation is even less useful than just the end ... but seeing both seems to be the helpful trade off here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.